Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Side by Side Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 18737004: List class was not initialized properly (it has type parameters). Do not preinitialize it incorrect… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 const AbstractTypeArguments& type_arguments = 240 const AbstractTypeArguments& type_arguments =
241 AbstractTypeArguments::ZoneHandle(type.arguments()); 241 AbstractTypeArguments::ZoneHandle(type.arguments());
242 const bool is_raw_type = type_arguments.IsNull() || 242 const bool is_raw_type = type_arguments.IsNull() ||
243 type_arguments.IsRaw(type_arguments.Length()); 243 type_arguments.IsRaw(type_arguments.Length());
244 if (is_raw_type) { 244 if (is_raw_type) {
245 const Register kClassIdReg = T0; 245 const Register kClassIdReg = T0;
246 // dynamic type argument, check only classes. 246 // dynamic type argument, check only classes.
247 __ LoadClassId(kClassIdReg, kInstanceReg); 247 __ LoadClassId(kClassIdReg, kInstanceReg);
248 __ BranchEqual(kClassIdReg, type_class.id(), is_instance_lbl); 248 __ BranchEqual(kClassIdReg, type_class.id(), is_instance_lbl);
249 // List is a very common case. 249 // List is a very common case.
250 if (type_class.IsListClass()) { 250 if (IsListClass(type_class)) {
251 GenerateListTypeCheck(kClassIdReg, is_instance_lbl); 251 GenerateListTypeCheck(kClassIdReg, is_instance_lbl);
252 } 252 }
253 return GenerateSubtype1TestCacheLookup( 253 return GenerateSubtype1TestCacheLookup(
254 token_pos, type_class, is_instance_lbl, is_not_instance_lbl); 254 token_pos, type_class, is_instance_lbl, is_not_instance_lbl);
255 } 255 }
256 // If one type argument only, check if type argument is Object or dynamic. 256 // If one type argument only, check if type argument is Object or dynamic.
257 if (type_arguments.Length() == 1) { 257 if (type_arguments.Length() == 1) {
258 const AbstractType& tp_argument = AbstractType::ZoneHandle( 258 const AbstractType& tp_argument = AbstractType::ZoneHandle(
259 type_arguments.TypeAt(0)); 259 type_arguments.TypeAt(0));
260 ASSERT(!tp_argument.IsMalformed()); 260 ASSERT(!tp_argument.IsMalformed());
(...skipping 1736 matching lines...) Expand 10 before | Expand all | Expand 10 after
1997 __ AddImmediate(SP, kDoubleSize); 1997 __ AddImmediate(SP, kDoubleSize);
1998 } 1998 }
1999 1999
2000 2000
2001 #undef __ 2001 #undef __
2002 2002
2003 2003
2004 } // namespace dart 2004 } // namespace dart
2005 2005
2006 #endif // defined TARGET_ARCH_MIPS 2006 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698