Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 18737004: List class was not initialized properly (it has type parameters). Do not preinitialize it incorrect… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 AbstractTypeArguments::ZoneHandle(type.arguments()); 241 AbstractTypeArguments::ZoneHandle(type.arguments());
242 const bool is_raw_type = type_arguments.IsNull() || 242 const bool is_raw_type = type_arguments.IsNull() ||
243 type_arguments.IsRaw(type_arguments.Length()); 243 type_arguments.IsRaw(type_arguments.Length());
244 if (is_raw_type) { 244 if (is_raw_type) {
245 const Register kClassIdReg = R2; 245 const Register kClassIdReg = R2;
246 // dynamic type argument, check only classes. 246 // dynamic type argument, check only classes.
247 __ LoadClassId(kClassIdReg, kInstanceReg); 247 __ LoadClassId(kClassIdReg, kInstanceReg);
248 __ CompareImmediate(kClassIdReg, type_class.id()); 248 __ CompareImmediate(kClassIdReg, type_class.id());
249 __ b(is_instance_lbl, EQ); 249 __ b(is_instance_lbl, EQ);
250 // List is a very common case. 250 // List is a very common case.
251 if (type_class.IsListClass()) { 251 if (IsListClass(type_class)) {
252 GenerateListTypeCheck(kClassIdReg, is_instance_lbl); 252 GenerateListTypeCheck(kClassIdReg, is_instance_lbl);
253 } 253 }
254 return GenerateSubtype1TestCacheLookup( 254 return GenerateSubtype1TestCacheLookup(
255 token_pos, type_class, is_instance_lbl, is_not_instance_lbl); 255 token_pos, type_class, is_instance_lbl, is_not_instance_lbl);
256 } 256 }
257 // If one type argument only, check if type argument is Object or dynamic. 257 // If one type argument only, check if type argument is Object or dynamic.
258 if (type_arguments.Length() == 1) { 258 if (type_arguments.Length() == 1) {
259 const AbstractType& tp_argument = AbstractType::ZoneHandle( 259 const AbstractType& tp_argument = AbstractType::ZoneHandle(
260 type_arguments.TypeAt(0)); 260 type_arguments.TypeAt(0));
261 ASSERT(!tp_argument.IsMalformed()); 261 ASSERT(!tp_argument.IsMalformed());
(...skipping 1582 matching lines...) Expand 10 before | Expand all | Expand 10 after
1844 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) { 1844 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
1845 __ vldrd(reg, Address(SP, kDoubleSize, Address::PostIndex)); 1845 __ vldrd(reg, Address(SP, kDoubleSize, Address::PostIndex));
1846 } 1846 }
1847 1847
1848 1848
1849 #undef __ 1849 #undef __
1850 1850
1851 } // namespace dart 1851 } // namespace dart
1852 1852
1853 #endif // defined TARGET_ARCH_ARM 1853 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698