Refactor native extension shared library lookup.

Refactor native extension shared library lookup.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33275

[Bill Hesse, 2014-03-04 12:58:06]

This refactoring is needed to get the platform-specific shared native library
filename earlier.  It also makes the code cleaner, I think.

[Søren Gjesse, 2014-03-04 13:09:02]

lgtm

https://codereview.chromium.org/186473003/diff/20001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/186473003/diff/20001/runtime/bin/builtin.dart...
runtime/bin/builtin.dart:267: // Returns the directory part, the filename part,
and the name
How about calling "directory part" for location?

https://codereview.chromium.org/186473003/diff/20001/runtime/bin/extensions.cc
File runtime/bin/extensions.cc (right):

https://codereview.chromium.org/186473003/diff/20001/runtime/bin/extensions.c...
runtime/bin/extensions.cc:22: Dart_Handle parent_library) {
extension_directory can be a http/https URI :-)

[Bill Hesse, 2014-03-04 14:36:31]

https://codereview.chromium.org/186473003/diff/20001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/186473003/diff/20001/runtime/bin/builtin.dart...
runtime/bin/builtin.dart:267: // Returns the directory part, the filename part,
and the name
On 2014/03/04 13:09:02, Søren Gjesse wrote:
> How about calling "directory part" for location?

Done.

https://codereview.chromium.org/186473003/diff/20001/runtime/bin/extensions.cc
File runtime/bin/extensions.cc (right):

https://codereview.chromium.org/186473003/diff/20001/runtime/bin/extensions.c...
runtime/bin/extensions.cc:22: Dart_Handle parent_library) {
On 2014/03/04 13:09:02, Søren Gjesse wrote:
> extension_directory can be a http/https URI :-)

Added back the check for http, added https.
Done.

[Bill Hesse, 2014-03-04 14:39:22]

Committed patchset #3 manually as r33275 (presubmit successful).

[Ivan Posva, 2014-03-04 20:03:56]

I like having most of the concat work being done in the Dart code, but I am not
sure how well that will hold up in the long term.

-Ivan

https://codereview.chromium.org/186473003/diff/40001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/186473003/diff/40001/runtime/bin/builtin.dart...
runtime/bin/builtin.dart:269: String _extensionPathFromUri(String userUri) {
Please remove the types in this file. They will only serve the purpose of
causing checked mode failures as can be seen here where we are returning a List
but the function is typed to return a String.

https://codereview.chromium.org/186473003/diff/40001/runtime/bin/builtin.dart...
runtime/bin/builtin.dart:296: filename = 'lib$name.so';
We will also have to have a plan to deal with different OS and architecture
combinations being served from the same location.

This didn't use to be as much of an issue as the extensions were only available
locally.