Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/extensions_macos.cc

Issue 186473003: Refactor native extension shared library lookup. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add check for loading from http(s): Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/builtin.dart ('K') | « runtime/bin/extensions_linux.cc ('k') | runtime/bin/extensions_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/extensions_macos.cc
diff --git a/runtime/bin/extensions_macos.cc b/runtime/bin/extensions_macos.cc
index bfda5e7f4420a3ee34a094f05d05b1318bb41d66..814f935db4ba2198da49161008e56adb0056704a 100644
--- a/runtime/bin/extensions_macos.cc
+++ b/runtime/bin/extensions_macos.cc
@@ -12,14 +12,8 @@
namespace dart {
namespace bin {
-void* Extensions::LoadExtensionLibrary(const char* library_path,
- const char* extension_name) {
- const char* strings[] = { library_path, "/lib",
- extension_name, ".dylib", NULL };
- char* library_file = Concatenate(strings);
- void* lib_handle = dlopen(library_file, RTLD_LAZY);
- free(library_file);
- return lib_handle;
+void* Extensions::LoadExtensionLibrary(const char* library_file) {
+ return dlopen(library_file, RTLD_LAZY);
}
void* Extensions::ResolveSymbol(void* lib_handle, const char* symbol) {
« runtime/bin/builtin.dart ('K') | « runtime/bin/extensions_linux.cc ('k') | runtime/bin/extensions_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698