Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: runtime/bin/extensions_android.cc

Issue 186473003: Refactor native extension shared library lookup. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add check for loading from http(s): Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/extensions_android.cc
diff --git a/runtime/bin/extensions_android.cc b/runtime/bin/extensions_android.cc
index 72c757f8769ee3c405e63ef72426fb082a0aa706..3d2688b3114c0c7992f8d61552e2acc0fe8736d2 100644
--- a/runtime/bin/extensions_android.cc
+++ b/runtime/bin/extensions_android.cc
@@ -12,14 +12,8 @@
namespace dart {
namespace bin {
-void* Extensions::LoadExtensionLibrary(const char* library_path,
- const char* extension_name) {
- const char* strings[] = { library_path, "/lib",
- extension_name, ".so", NULL };
- char* library_file = Concatenate(strings);
- void* lib_handle = dlopen(library_file, RTLD_LAZY);
- free(library_file);
- return lib_handle;
+void* Extensions::LoadExtensionLibrary(const char* library_file) {
+ return dlopen(library_file, RTLD_LAZY);
}
void* Extensions::ResolveSymbol(void* lib_handle, const char* symbol) {

Powered by Google App Engine
This is Rietveld 408576698