Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184153002: - Update runtime/third_party/double-conversion to version 1.1.5. (Closed)

Created:
6 years, 9 months ago by Ivan Posva
Modified:
6 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Update runtime/third_party/double-conversion to version 1.1.5. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=33167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+876 lines, -457 lines) Patch
A runtime/third_party/double-conversion/.gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/third_party/double-conversion/AUTHORS View 1 chunk +3 lines, -0 lines 0 comments Download
A runtime/third_party/double-conversion/Changelog View 1 chunk +33 lines, -0 lines 0 comments Download
M runtime/third_party/double-conversion/README.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/third_party/double-conversion/src/bignum.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/third_party/double-conversion/src/bignum.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M runtime/third_party/double-conversion/src/bignum-dtoa.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/third_party/double-conversion/src/bignum-dtoa.cc View 16 chunks +62 lines, -74 lines 0 comments Download
M runtime/third_party/double-conversion/src/cached-powers.cc View 1 chunk +1 line, -0 lines 0 comments Download
D runtime/third_party/double-conversion/src/double.h View 1 chunk +0 lines, -245 lines 0 comments Download
M runtime/third_party/double-conversion/src/double-conversion.h View 9 chunks +45 lines, -7 lines 0 comments Download
M runtime/third_party/double-conversion/src/double-conversion.cc View 24 chunks +89 lines, -45 lines 0 comments Download
M runtime/third_party/double-conversion/src/double-conversion.gypi View 1 chunk +1 line, -1 line 0 comments Download
M runtime/third_party/double-conversion/src/fast-dtoa.h View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/third_party/double-conversion/src/fast-dtoa.cc View 10 chunks +23 lines, -14 lines 0 comments Download
M runtime/third_party/double-conversion/src/fixed-dtoa.cc View 6 chunks +8 lines, -6 lines 0 comments Download
A runtime/third_party/double-conversion/src/ieee.h View 1 chunk +402 lines, -0 lines 0 comments Download
M runtime/third_party/double-conversion/src/strtod.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/third_party/double-conversion/src/strtod.cc View 7 chunks +160 lines, -46 lines 0 comments Download
M runtime/third_party/double-conversion/src/utils.h View 4 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
6 years, 9 months ago (2014-02-28 06:18:28 UTC) #1
floitsch
LGTM. The v1.1 branch already contains support for floats (not just doubles), which Dart actually ...
6 years, 9 months ago (2014-02-28 10:18:29 UTC) #2
Ivan Posva
6 years, 9 months ago (2014-02-28 17:48:46 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r33167.

Powered by Google App Engine
This is Rietveld 408576698