guard against invalid request id / method

guard against invalid request id / method

BUG=
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33337

[Brian Wilkerson, 2014-03-05 16:15:16]

LGTM

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:83: if (params is Map) {
So it looks like we're returning null if the format is not correct. If that's
the case, shouldn't we be returning null if params is not a Map?

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:84: params.forEach((String key, Object
value) {
Should we test that the key is always a String?

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/test/pro...
File pkg/analysis_server/test/protocol_test.dart (right):

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_test.dart:127: static void
fromJson_invalidMethod() {
It would be good to have a test "fromJson_invalidParams".

[danrubel, 2014-03-05 18:39:07]

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:83: if (params is Map) {
On 2014/03/05 16:15:16, Brian Wilkerson wrote:
> So it looks like we're returning null if the format is not correct. If that's
> the case, shouldn't we be returning null if params is not a Map?

Good point. Done.

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:84: params.forEach((String key, Object
value) {
On 2014/03/05 16:15:16, Brian Wilkerson wrote:
> Should we test that the key is always a String?

I don't think we want to restrict the value of a param to a String.

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/test/pro...
File pkg/analysis_server/test/protocol_test.dart (right):

https://codereview.chromium.org/180743020/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_test.dart:127: static void
fromJson_invalidMethod() {
On 2014/03/05 16:15:16, Brian Wilkerson wrote:
> It would be good to have a test "fromJson_invalidParams".

Done.

[danrubel, 2014-03-05 18:40:35]

Committed patchset #3 manually as r33337 (presubmit successful).