guard against invalid request id / method

pkg/analysis_server/lib/src/protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library protocol;
 
 import 'dart:convert' show JsonDecoder;
 
 /**
  * Instances of the class [Request] represent a request that was received.
@@ skipping 55 matching lines @@
    *
    * where the parameters are optional and can contain any number of name/value
    * pairs.
    */
   factory Request.fromString(String data) {
     try {
       var result = DECODER.convert(data);
       if (result is! Map) {
         return null;
       }
-      String id = result[Request.ID];
-      String method = result[Request.METHOD];
+      var id = result[Request.ID];
+      var method = result[Request.METHOD];
+      if (id is! String || method is! String) {
+        return null;
+      }
       var params = result[Request.PARAMS];
       Request request = new Request(id, method);
       if (params is Map) {

[Brian Wilkerson, 2014/03/05 16:15:16]

So it looks like we're returning null if the format is not correct. If that's
the case, shouldn't we be returning null if params is not a Map?

[danrubel, 2014/03/05 18:39:07]

Good point. Done.

         params.forEach((String key, Object value) {

[Brian Wilkerson, 2014/03/05 16:15:16]

Should we test that the key is always a String?

[danrubel, 2014/03/05 18:39:07]

I don't think we want to restrict the value of a param to a String.

           request.setParameter(key, value);
         });
       }
       return request;
     } catch (exception) {
       return null;
     }
   }
 
   /**
@@ skipping 482 matching lines @@
   /**
    * The response to be returned as a result of the failure.
    */
   final Response response;
 
   /**
    * Initialize a newly created exception to return the given reponse.
    */
   RequestFailure(this.response);
 }