guard against invalid request id / method

pkg/analysis_server/test/protocol_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.protocol;
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:unittest/matcher.dart';
 import 'package:unittest/unittest.dart';
 import 'dart:convert';
 
 main() {
   group('Notification', () {
     test('getParameter_defined', NotificationTest.getParameter_defined);
     test('getParameter_undefined', NotificationTest.getParameter_undefined);
     test('fromJson', NotificationTest.fromJson);
     test('fromJson_withParams', NotificationTest.fromJson_withParams);
   });
   group('Request', () {
     test('getParameter_defined', RequestTest.getParameter_defined);
     test('getParameter_undefined', RequestTest.getParameter_undefined);
     test('getRequiredParameter_defined', RequestTest.getRequiredParameter_defined);
     test('getRequiredParameter_undefined', RequestTest.getRequiredParameter_undefined);
     test('fromJson', RequestTest.fromJson);
+    test('fromJson_invalidId', RequestTest.fromJson_invalidId);
+    test('fromJson_invalidMethod', RequestTest.fromJson_invalidMethod);
     test('fromJson_withParams', RequestTest.fromJson_withParams);
     test('toJson', RequestTest.toJson);
     test('toJson_withParams', RequestTest.toJson_withParams);
   });
   group('Response', () {
     test('create_contextDoesNotExist', ResponseTest.create_contextDoesNotExist);
     test('create_invalidRequestFormat', ResponseTest.create_invalidRequestFormat);
     test('create_missingRequiredParameter', ResponseTest.create_missingRequiredParameter);
     test('create_unknownRequest', ResponseTest.create_unknownRequest);
     test('setResult', ResponseTest.setResult);
@@ skipping 74 matching lines @@
   }
 
   static void fromJson() {
     Request original = new Request('one', 'aMethod');
     String json = new JsonEncoder(null).convert(original.toJson());
     Request request = new Request.fromString(json);
     expect(request.id, equals('one'));
     expect(request.method, equals('aMethod'));
   }
 
+  static void fromJson_invalidId() {
+    String json = '{"id":{"one":"two"},"method":"aMethod","params":{"foo":"bar"}}';
+    Request request = new Request.fromString(json);
+    expect(request, isNull);
+  }
+
+  static void fromJson_invalidMethod() {

[Brian Wilkerson, 2014/03/05 16:15:16]

It would be good to have a test "fromJson_invalidParams".

[danrubel, 2014/03/05 18:39:07]

Done.

+    String json = '{"id":"one","method":{"boo":"aMethod"},"params":{"foo":"bar"}}';
+    Request request = new Request.fromString(json);
+    expect(request, isNull);
+  }
+
   static void fromJson_withParams() {
     Request original = new Request('one', 'aMethod');
     original.setParameter('foo', 'bar');
     String json = new JsonEncoder(null).convert(original.toJson());
     Request request = new Request.fromString(json);
     expect(request.id, equals('one'));
     expect(request.method, equals('aMethod'));
     expect(request.getParameter('foo'), equals('bar'));
   }
 
@@ skipping 90 matching lines @@
   static void fromJson_withResult() {
     Response original = new Response('myId');
     original.setResult('foo', 'bar');
     Response response = new Response.fromJson(original.toJson());
     expect(response.id, equals('myId'));
     Map<String, Object> result = response.result;
     expect(result.length, equals(1));
     expect(result['foo'], equals('bar'));
   }
 }