Issue 18052029: Use package:stack_trace in unittest.

Issue 18052029: Use package:stack_trace in unittest. (Closed)

Created:
7 years, 5 months ago by nweiz

Modified:
7 years, 5 months ago

Reviewers:
gram

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use package:stack_trace in unittest. R=gram@google.com Committed: https://code.google.com/p/dart/source/detail?r=24652

Patch Set 2 : Code review change. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -233 lines)			Patch
M	pkg/unittest/lib/compact_vm_config.dart	View		2 chunks	+5 lines, -7 lines	0 comments	Download
M	pkg/unittest/lib/html_config.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/unittest/lib/html_enhanced_config.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/unittest/lib/interactive_html_config.dart	View		4 chunks	+23 lines, -6 lines	0 comments	Download
M	pkg/unittest/lib/src/config.dart	View		5 chunks	+16 lines, -22 lines	0 comments	Download
M	pkg/unittest/lib/src/test_case.dart	View		7 chunks	+21 lines, -28 lines	0 comments	Download
M	pkg/unittest/lib/src/utils.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	pkg/unittest/lib/unittest.dart	View	1	5 chunks	+24 lines, -76 lines	0 comments	Download
M	pkg/unittest/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/command_line_config.dart	View		2 chunks	+3 lines, -90 lines	0 comments	Download
M	utils/testrunner/standard_test_runner.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gram

lgtm https://codereview.chromium.org/18052029/diff/1/pkg/unittest/lib/unittest.dart File pkg/unittest/lib/unittest.dart (right): https://codereview.chromium.org/18052029/diff/1/pkg/unittest/lib/unittest.dart#newcode890 pkg/unittest/lib/unittest.dart:890: return new Trace(trace.frames.takeWhile((frame) { Please add a descriptive ...

7 years, 5 months ago (2013-06-28 23:49:14 UTC) #2

nweiz

I'm going to hold off on committing this until Monday so I don't break the ...

7 years, 5 months ago (2013-06-29 00:04:59 UTC) #3

nweiz

7 years, 5 months ago (2013-07-01 20:11:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24652 (presubmit successful).

Expand Messages | Collapse Messages