pkg/unittest/lib/html_config.dart - Issue 18052029: Use package:stack_trace in unittest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/unittest/lib/html_config.dart

Issue 18052029: Use package:stack_trace in unittest. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review change. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/unittest/lib/html_config.dart

diff --git a/pkg/unittest/lib/html_config.dart b/pkg/unittest/lib/html_config.dart

index 303afb63b7a67b93ade97b491a8866e76cc97d84..86123cf3d1681805409d3620a871c9405e051254 100644

--- a/pkg/unittest/lib/html_config.dart

+++ b/pkg/unittest/lib/html_config.dart

@@ -80,7 +80,9 @@ String _toHtml(TestCase test_) {

</tr>''';

if (test_.stackTrace != null) {

- html = '$html<tr><td></td><td colspan="2"><pre>${_htmlEscape(test_.stackTrace)}</pre></td></tr>';

+ html = '$html<tr><td></td><td colspan="2"><pre>' +

+ _htmlEscape(test_.stackTrace.toString()) +

+ '</pre></td></tr>';

}

return html;

« no previous file with comments | « pkg/unittest/lib/compact_vm_config.dart ('k') | pkg/unittest/lib/html_enhanced_config.dart » ('j') | no next file with comments »