Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: pkg/unittest/lib/compact_vm_config.dart

Issue 18052029: Use package:stack_trace in unittest. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review change. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/unittest/lib/html_config.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/compact_vm_config.dart
diff --git a/pkg/unittest/lib/compact_vm_config.dart b/pkg/unittest/lib/compact_vm_config.dart
index 7c4b0d696907051173f1dbcdeaddff409db1ad26..db42cfc2b3e9ce127186912bf1b0ce52a2535512 100644
--- a/pkg/unittest/lib/compact_vm_config.dart
+++ b/pkg/unittest/lib/compact_vm_config.dart
@@ -11,7 +11,9 @@
library compact_vm_config;
import 'dart:io';
+
import 'unittest.dart';
+import 'src/utils.dart';
import 'vm_config.dart';
const String _GREEN = '\u001b[32m';
@@ -48,19 +50,15 @@ class CompactVMConfiguration extends VMConfiguration {
_progressLine(_start, _pass, _fail, test.description);
print('');
if (test.message != '') {
- print(_indent(test.message));
+ print(indent(test.message));
}
- if (test.stackTrace != null && test.stackTrace != '') {
- print(_indent(test.stackTrace));
+ if (test.stackTrace != null) {
+ print(indent(test.stackTrace.toString()));
}
}
}
- String _indent(String str) {
- return str.split("\n").map((line) => " $line").join("\n");
- }
-
void onSummary(int passed, int failed, int errors, List<TestCase> results,
String uncaughtError) {
var success = false;
« no previous file with comments | « no previous file | pkg/unittest/lib/html_config.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698