Issue 180243022: Fix fromEnvironment when called from isolates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180243022: Fix fromEnvironment when called from isolates. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen

Modified:
6 years, 9 months ago

Reviewers:
Søren Gjesse, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -18 lines)			Patch
M	runtime/lib/bool.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/integers.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/string.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.h	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+1 line, -15 lines	0 comments	Download
M	tests/corelib/bool_from_environment_default_value_test.dart	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	tests/corelib/int_from_environment_default_value_test.dart	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	tests/corelib/string_from_environment_default_value.dart	View	1 chunk	+11 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Anders Johnsen

6 years, 9 months ago (2014-03-06 09:17:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33363 (presubmit successful).