runtime/lib/string.cc - Issue 180243022: Fix fromEnvironment when called from isolates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string.cc

Issue 180243022: Fix fromEnvironment when called from isolates. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/string.cc

diff --git a/runtime/lib/string.cc b/runtime/lib/string.cc

index 47a82ed60692bcb932bf92dfc39d335b6720b5a3..1a2e60b19752996cd3c3a7b826b4199d82ec56d1 100644

--- a/runtime/lib/string.cc

+++ b/runtime/lib/string.cc

@@ -19,6 +19,7 @@ DEFINE_NATIVE_ENTRY(String_fromEnvironment, 3) {

GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(1));

GET_NATIVE_ARGUMENT(String, default_value, arguments->NativeArgAt(2));

// Call the embedder to supply us with the environment.

+ Api::Scope api_scope();

Dart_EnvironmentCallback callback = isolate->environment_callback();

if (callback != NULL) {

Dart_Handle result = callback(Api::NewHandle(isolate, name.raw()));

« no previous file with comments | « runtime/lib/integers.cc ('k') | runtime/vm/dart_api_impl.h » ('j') | no next file with comments »