Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: runtime/vm/parser.cc

Issue 180243022: Fix fromEnvironment when called from isolates. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.h ('k') | tests/corelib/bool_from_environment_default_value_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index 891649170146c9ac5dc65c831bfce63e4bb1358c..7477af6bff1b2cd80ee45a91832adca317d9d22a 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -4855,20 +4855,6 @@ void Parser::ParseTopLevelAccessor(TopLevel* top_level,
}
-class DartApiScope : public StackResource {
- public:
- explicit DartApiScope(Isolate* isolate) : StackResource(isolate) {
- Dart_EnterScope();
- }
- ~DartApiScope() {
- Dart_ExitScope();
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(DartApiScope);
-};
-
-
RawObject* Parser::CallLibraryTagHandler(Dart_LibraryTag tag,
intptr_t token_pos,
const String& url) {
@@ -4885,7 +4871,7 @@ RawObject* Parser::CallLibraryTagHandler(Dart_LibraryTag tag,
// Block class finalization attempts when calling into the library
// tag handler.
isolate()->BlockClassFinalization();
- DartApiScope api_scope(isolate());
+ Api::Scope api_scope(isolate());
Dart_Handle result = handler(tag,
Api::NewHandle(isolate(), library_.raw()),
Api::NewHandle(isolate(), url.raw()));
« no previous file with comments | « runtime/vm/dart_api_impl.h ('k') | tests/corelib/bool_from_environment_default_value_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698