Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 179803004: Assign invalid name to globalized closures. (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove debug-print and add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/lib/mirrors/globalized_closures2_test.dart View 1 1 chunk +37 lines, -0 lines 0 comments Download
A tests/lib/mirrors/globalized_closures_test.dart View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
6 years, 10 months ago (2014-02-25 21:36:34 UTC) #1
karlklose
LGTM.
6 years, 10 months ago (2014-02-26 13:25:38 UTC) #2
floitsch
6 years, 10 months ago (2014-02-26 13:47:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r33061 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698