Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 179803004: Assign invalid name to globalized closures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove debug-print and add tests. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('k') | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart
index b790ca9dac00bc652ffc088cd0740bb1f046adcb..efe9dce44b0cf6ecc8998a38e13d1dd9b424c15f 100644
--- a/sdk/lib/_internal/lib/js_mirrors.dart
+++ b/sdk/lib/_internal/lib/js_mirrors.dart
@@ -70,9 +70,9 @@ class JsMirrorSystem implements MirrorSystem {
JsTypeMirror get dynamicType => _dynamicType;
JsTypeMirror get voidType => _voidType;
- final static JsTypeMirror _dynamicType =
+ static final JsTypeMirror _dynamicType =
new JsTypeMirror(const Symbol('dynamic'));
- final static JsTypeMirror _voidType = new JsTypeMirror(const Symbol('void'));
+ static final JsTypeMirror _voidType = new JsTypeMirror(const Symbol('void'));
static final Map<String, List<LibraryMirror>> librariesByName =
computeLibrariesByName();
@@ -2624,7 +2624,7 @@ List extractMetadata(victim) {
(int i) => getMetadata(i)).toList();
}
-List<JsVariableMirror> parseCompactFieldSpecification(
+void parseCompactFieldSpecification(
JsDeclarationMirror owner,
fieldSpecification,
bool isStatic,
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('k') | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698