Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tests/lib/mirrors/globalized_closures_test.dart

Issue 179803004: Assign invalid name to globalized closures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove debug-print and add tests. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/globalized_closures2_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/globalized_closures_test.dart
diff --git a/tests/lib/mirrors/globalized_closures_test.dart b/tests/lib/mirrors/globalized_closures_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..6e459e9b13c9ad994b908947f89fa834a508ec0a
--- /dev/null
+++ b/tests/lib/mirrors/globalized_closures_test.dart
@@ -0,0 +1,37 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Dart2js crashed on this example. It globalized closures and created
+// top-level classes for closures (here the globalized_closure). There was a
+// name-clash with the global "main_closure" class which led to a crash.
+
+library main;
+
+import 'dart:mirrors';
+
+import 'package:expect/expect.dart';
+
+class main_closure {
+}
+
+confuse(x) {
+ if (new DateTime.now().millisecondsSinceEpoch == 42) return confuse(() => 42);
+ return x;
+}
+
+main() {
+ new main_closure();
+ var globalized_closure = confuse(() => 499);
+ globalized_closure();
+ final ms = currentMirrorSystem();
+ var lib = ms.findLibrary(#main);
+ var collectedParents = [];
+ var classes = lib.declarations.values;
+ for (var c in classes) {
+ if (c is ClassMirror && c.superclass != null) {
+ collectedParents.add(MirrorSystem.getName(c.superclass.simpleName));
+ }
+ };
+ Expect.listEquals(["Object"], collectedParents); /// 00: ok
+}
« no previous file with comments | « tests/lib/mirrors/globalized_closures2_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698