Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177733002: Revert r32930 (Add more timing information in the VM to track time...) (Closed)

Created:
6 years, 10 months ago by Florian Schneider
Modified:
6 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anders Johnsen, kasperl
Visibility:
Public.

Description

Revert r32930 (Add more timing information in the VM to track time...) It caused severe performance regressions that should be addressed. TBR=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -308 lines) Patch
M runtime/lib/bool.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/lib/integers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/lib/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/lib/string.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/benchmark_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/code_descriptors_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/compiler.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/compiler_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/dart.cc View 3 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.h View 2 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 12 chunks +13 lines, -15 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 21 chunks +25 lines, -10 lines 0 comments Download
M runtime/vm/dart_entry.cc View 2 chunks +12 lines, -15 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/native_entry.h View 2 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/native_entry.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/parser.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M runtime/vm/runtime_entry.h View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M runtime/vm/service_test.cc View 25 chunks +24 lines, -30 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/timer.h View 3 chunks +43 lines, -8 lines 0 comments Download
M runtime/vm/timer.cc View 2 chunks +1 line, -12 lines 0 comments Download
D runtime/vm/timer_scope.h View 1 chunk +0 lines, -144 lines 0 comments Download
M runtime/vm/unit_test.h View 5 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
6 years, 10 months ago (2014-02-24 12:15:05 UTC) #1
Florian Schneider
6 years, 10 months ago (2014-02-24 12:16:16 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r32959 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698