Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: runtime/lib/string.cc

Issue 177733002: Revert r32930 (Add more timing information in the VM to track time...) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/lib/isolate.cc ('k') | runtime/vm/benchmark_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/bootstrap_natives.h" 5 #include "vm/bootstrap_natives.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "vm/exceptions.h" 8 #include "vm/exceptions.h"
9 #include "vm/dart_api_impl.h" 9 #include "vm/dart_api_impl.h"
10 #include "vm/isolate.h" 10 #include "vm/isolate.h"
11 #include "vm/native_entry.h" 11 #include "vm/native_entry.h"
12 #include "vm/object.h" 12 #include "vm/object.h"
13 #include "vm/symbols.h" 13 #include "vm/symbols.h"
14 #include "vm/unicode.h" 14 #include "vm/unicode.h"
15 15
16 namespace dart { 16 namespace dart {
17 17
18 DEFINE_NATIVE_ENTRY(String_fromEnvironment, 3) { 18 DEFINE_NATIVE_ENTRY(String_fromEnvironment, 3) {
19 GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(1)); 19 GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(1));
20 GET_NATIVE_ARGUMENT(String, default_value, arguments->NativeArgAt(2)); 20 GET_NATIVE_ARGUMENT(String, default_value, arguments->NativeArgAt(2));
21 // Call the embedder to supply us with the environment. 21 // Call the embedder to supply us with the environment.
22 Dart_EnvironmentCallback callback = isolate->environment_callback(); 22 Dart_EnvironmentCallback callback = isolate->environment_callback();
23 if (callback != NULL) { 23 if (callback != NULL) {
24 VmToNativeTimerScope timer(isolate);
25 Dart_Handle result = callback(Api::NewHandle(isolate, name.raw())); 24 Dart_Handle result = callback(Api::NewHandle(isolate, name.raw()));
26 if (Dart_IsString(result)) { 25 if (Dart_IsString(result)) {
27 const Object& value = 26 const Object& value =
28 Object::Handle(isolate, Api::UnwrapHandle(result)); 27 Object::Handle(isolate, Api::UnwrapHandle(result));
29 return Symbols::New(String::Cast(value)); 28 return Symbols::New(String::Cast(value));
30 } else if (Dart_IsError(result)) { 29 } else if (Dart_IsError(result)) {
31 const Object& error = 30 const Object& error =
32 Object::Handle(isolate, Api::UnwrapHandle(result)); 31 Object::Handle(isolate, Api::UnwrapHandle(result));
33 Exceptions::ThrowArgumentError( 32 Exceptions::ThrowArgumentError(
34 String::Handle( 33 String::Handle(
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 ? String::Handle(OneByteString::New(length_value, Heap::kNew)) 348 ? String::Handle(OneByteString::New(length_value, Heap::kNew))
350 : String::Handle(TwoByteString::New(length_value, Heap::kNew)); 349 : String::Handle(TwoByteString::New(length_value, Heap::kNew));
351 NoGCScope no_gc; 350 NoGCScope no_gc;
352 351
353 uint16_t* data_position = reinterpret_cast<uint16_t*>(codeUnits.DataAddr(0)); 352 uint16_t* data_position = reinterpret_cast<uint16_t*>(codeUnits.DataAddr(0));
354 String::Copy(result, 0, data_position, length_value); 353 String::Copy(result, 0, data_position, length_value);
355 return result.raw(); 354 return result.raw();
356 } 355 }
357 356
358 } // namespace dart 357 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/lib/isolate.cc ('k') | runtime/vm/benchmark_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698