Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: runtime/vm/timer.h

Issue 177733002: Revert r32930 (Add more timing information in the VM to track time...) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/timer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timer.h
===================================================================
--- runtime/vm/timer.h (revision 32958)
+++ runtime/vm/timer.h (working copy)
@@ -83,7 +83,6 @@
V(time_compilation, "Function compilation") \
V(time_bootstrap, "Bootstrap of core classes") \
V(time_dart_execution, "Dart execution") \
- V(time_native_execution, "Native code execution") \
V(time_total_runtime, "Total runtime for isolate") \
// Maintains a list of timers per isolate.
@@ -99,7 +98,6 @@
#undef TIMER_FIELD_ACCESSOR
void ReportTimers();
- void ReportTimerState(const char* prefix);
void PrintTimersToJSONProperty(JSONObject* jsobj);
@@ -112,15 +110,52 @@
};
// Timer Usage.
-#define START_TIMER(isolate, name) \
- isolate->timer_list().name().Start();
+#define START_TIMER(name) \
+ Isolate::Current()->timer_list().name().Start();
-#define STOP_TIMER(isolate, name) \
- isolate->timer_list().name().Stop();
+#define STOP_TIMER(name) \
+ Isolate::Current()->timer_list().name().Stop();
-#define TIMER_STATE(isolate, prefix) \
- isolate->timer_list().ReportTimerState(prefix);
+// The class TimerScope is used to start and stop a timer within a scope.
+// It is used as follows:
+// {
+// TIMERSCOPE(name_of_timer);
+// ....
+// .....
+// code that needs to be timed.
+// ....
+// }
+class TimerScope : public StackResource {
+ public:
+ TimerScope(bool flag, Timer* timer, BaseIsolate* isolate = NULL)
+ : StackResource(isolate), flag_(flag), nested_(false), timer_(timer) {
+ if (flag_) {
+ if (!timer_->running()) {
+ timer_->Start();
+ } else {
+ nested_ = true;
+ }
+ }
+ }
+ ~TimerScope() {
+ if (flag_) {
+ if (!nested_) {
+ timer_->Stop();
+ }
+ }
+ }
+ private:
+ bool flag_;
+ bool nested_;
+ Timer* timer_;
+ DISALLOW_COPY_AND_ASSIGN(TimerScope);
+};
+
+#define TIMERSCOPE(name) \
+ TimerScope vm_internal_timer_(true, \
+ &(Isolate::Current()->timer_list().name()))
+
} // namespace dart
#endif // VM_TIMER_H_
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/timer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698