Re-apply 'Fix fromEnvironment when called from isolates.'

Re-apply 'Fix fromEnvironment when called from isolates.'

Old Review URL: https://codereview.chromium.org//186393004

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=33274

[Anders Johnsen, 2014-03-04 14:22:45]

No changes from original - I was not able to find the error that was suspected.

TBR

[Anders Johnsen, 2014-03-04 14:23:02]

Committed patchset #1 manually as r33274 (presubmit successful).

[Søren Gjesse, 2014-03-04 15:04:26]

lgtm

[Ivan Posva, 2014-03-04 18:27:21]

DBC -ip

https://codereview.chromium.org/177353006/diff/1/runtime/lib/bool.cc
File runtime/lib/bool.cc (right):

https://codereview.chromium.org/177353006/diff/1/runtime/lib/bool.cc#newcode24
runtime/lib/bool.cc:24: Dart_EnterScope();
You are mixing external Dart API with internal accesses which is bound to cause
issues.

[Anders Johnsen, 2014-03-05 08:03:51]

https://codereview.chromium.org/177353006/diff/1/runtime/lib/bool.cc
File runtime/lib/bool.cc (right):

https://codereview.chromium.org/177353006/diff/1/runtime/lib/bool.cc#newcode24
runtime/lib/bool.cc:24: Dart_EnterScope();
On 2014/03/04 18:27:21, Ivan Posva wrote:
> You are mixing external Dart API with internal accesses which is bound to
cause
> issues.

Yep, what I realized :)

Note that in the main isolate, the scope is set here, however, for other
isolates, the scope is not set. Is that a bug, or more a coincidence?