Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 186393004: Fix fromEnvironment when called from isolates. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix fromEnvironment when called from isolates. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33264

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M runtime/lib/bool.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/lib/integers.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/lib/string.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/corelib/bool_from_environment_default_value_test.dart View 1 chunk +11 lines, -1 line 0 comments Download
M tests/corelib/int_from_environment_default_value_test.dart View 1 1 chunk +11 lines, -1 line 0 comments Download
M tests/corelib/string_from_environment_default_value.dart View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 9 months ago (2014-03-04 10:07:32 UTC) #1
Søren Gjesse
lgtm Potential merge to stable.
6 years, 9 months ago (2014-03-04 10:21:41 UTC) #2
Anders Johnsen
6 years, 9 months ago (2014-03-04 10:26:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r33264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698