Re-apply 'Fix fromEnvironment when called from isolates.'

runtime/lib/bool.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "include/dart_api.h"
 #include "vm/bigint_operations.h"
 #include "vm/dart_entry.h"
 #include "vm/dart_api_impl.h"
 #include "vm/exceptions.h"
 #include "vm/isolate.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 DEFINE_NATIVE_ENTRY(Bool_fromEnvironment, 3) {
   GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(1));
   GET_NATIVE_ARGUMENT(Bool, default_value, arguments->NativeArgAt(2));
   // Call the embedder to supply us with the environment.
+  Dart_EnterScope();

[Ivan Posva, 2014/03/04 18:27:21]

You are mixing external Dart API with internal accesses which is bound to cause
issues.

[Anders Johnsen, 2014/03/05 08:03:52]

Yep, what I realized :)

Note that in the main isolate, the scope is set here, however, for other
isolates, the scope is not set. Is that a bug, or more a coincidence?

   Dart_EnvironmentCallback callback = isolate->environment_callback();
   if (callback != NULL) {
     Dart_Handle result = callback(Api::NewHandle(isolate, name.raw()));
     if (Dart_IsString(result)) {
       const char *chars;
       Dart_StringToCString(result, &chars);
       if (strcmp("true", chars) == 0) return Bool::True().raw();
       if (strcmp("false", chars) == 0) return Bool::False().raw();
     } else if (Dart_IsError(result)) {
       const Object& error =
           Object::Handle(isolate, Api::UnwrapHandle(result));
       Exceptions::ThrowArgumentError(
           String::Handle(
               String::New(Error::Cast(error).ToErrorCString())));
     } else if (!Dart_IsNull(result)) {
       Exceptions::ThrowArgumentError(
           String::Handle(String::New("Illegal environment value")));
     }
   }
+  Dart_ExitScope();
   return default_value.raw();
 }
 
 }  // namespace dart