Add accumulator to allocation profiler

Add user resetable accumulator to allocation profiler.
Display aggregate of new and old space in a separate table.
Speed up display of tables by 10x.
Fix heap display bug (heap stats were always for new space).
Keep sort across refreshes.

R=turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33220

[turnidge, 2014-02-27 18:29:13]

lgtm, with comments.

https://codereview.chromium.org/173013004/diff/60001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart
(right):

https://codereview.chromium.org/173013004/diff/60001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart:33:
var _simpleChart;
Is there a better name than simpleDataTable?   That sounds more like a class
name than a variable name.  Maybe accumulatorDataTable?

Also, maybe add a one-liner for each table/chart pair that says what each is
for.

https://codereview.chromium.org/173013004/diff/60001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart:148:
bool _shouldSkip(Map v) {
This function is a bit cryptic.  Should skip what?  And the variable names (v,
n, o, i) don't help me figure it out.  Could you make the naming more
descriptive and/or add a comment?

https://codereview.chromium.org/173013004/diff/60001/runtime/vm/class_table.h
File runtime/vm/class_table.h (right):

https://codereview.chromium.org/173013004/diff/60001/runtime/vm/class_table.h...
runtime/vm/class_table.h:51: intptr_t accumulator_size_old_space_offset;
 Notes from our offline discussion:

struct AllocStats {
  intptr_t old_count;
  intptr_t new_count;
  intptr_t old_size;
  intptr_t new_size;

  AddOld(intptr_t sz);
  AddNew(intptr_t sz);
  Reset();
}

AllocStats pre_gc;
AllocStats post_gc;

AllocStats recent;
AllocStats accumulated;
AllocStats last_reset;

https://codereview.chromium.org/173013004/diff/60001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/173013004/diff/60001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1088: return true;
Add a heartbeat test.  I don't care if it is simple.

[Cutch, 2014-02-27 21:50:32]

PTAL

https://codereview.chromium.org/173013004/diff/60001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart
(right):

https://codereview.chromium.org/173013004/diff/60001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart:33:
var _simpleChart;
On 2014/02/27 18:29:13, turnidge wrote:
> Is there a better name than simpleDataTable?   That sounds more like a class
> name than a variable name.  Maybe accumulatorDataTable?
> 
> Also, maybe add a one-liner for each table/chart pair that says what each is
> for.

I've renamed it to "combined", which is a better name.

https://codereview.chromium.org/173013004/diff/60001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart:148:
bool _shouldSkip(Map v) {
On 2014/02/27 18:29:13, turnidge wrote:
> This function is a bit cryptic.  Should skip what?  And the variable names (v,
> n, o, i) don't help me figure it out.  Could you make the naming more
> descriptive and/or add a comment?

Cleaned up. renamed to _classHasNoAllocations.

https://codereview.chromium.org/173013004/diff/60001/runtime/vm/class_table.h
File runtime/vm/class_table.h (right):

https://codereview.chromium.org/173013004/diff/60001/runtime/vm/class_table.h...
runtime/vm/class_table.h:51: intptr_t accumulator_size_old_space_offset;
On 2014/02/27 18:29:13, turnidge wrote:
>  Notes from our offline discussion:
> 
> struct AllocStats {
>   intptr_t old_count;
>   intptr_t new_count;
>   intptr_t old_size;
>   intptr_t new_size;
> 
>   AddOld(intptr_t sz);
>   AddNew(intptr_t sz);
>   Reset();
> }
> 
> AllocStats pre_gc;
> AllocStats post_gc;
> 
> AllocStats recent;
> AllocStats accumulated;
> AllocStats last_reset;

Done.

https://codereview.chromium.org/173013004/diff/60001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/173013004/diff/60001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1088: return true;
On 2014/02/27 18:29:13, turnidge wrote:
> Add a heartbeat test.  I don't care if it is simple.

Done.

[turnidge, 2014-02-28 17:32:46]

lgtm

[Cutch, 2014-03-03 15:39:15]

Committed patchset #5 manually as r33220 (presubmit successful).