runtime/bin/vmservice/client/lib/src/observatory/chart.dart - Issue 173013004: Add accumulator to allocation profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory/chart.dart

Issue 173013004: Add accumulator to allocation profiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/client/lib/src/observatory/chart.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory/chart.dart b/runtime/bin/vmservice/client/lib/src/observatory/chart.dart

index dc3f1923da8f7e25e1753be2d52815711ba448a5..37204e636a9b1ee6e2a4fb8e4d025bb0de937c8b 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory/chart.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory/chart.dart

@@ -93,12 +93,11 @@ class Chart {

/// with the current sort settings.

void refreshOptionsSortInfo() {

var props = _chart.callMethod('getSortInfo');

- print(options);

- if (props != null) {

+ if ((props != null) && (props['column'] != -1)) {

+ // Preserve current sort settings.

options['sortColumn'] = props['column'];

options['sortAscending'] = props['ascending'];

}

- print(options);

}

/// Draw this chart using [table] and the current [options].

« no previous file with comments | « no previous file | runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart » ('j') | no next file with comments »