Add accumulator to allocation profiler

runtime/vm/class_table.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_CLASS_TABLE_H_
 #define VM_CLASS_TABLE_H_
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 
@@ skipping 20 matching lines @@
   intptr_t live_after_gc_new_space;
   intptr_t live_size_after_gc_old_space;
   intptr_t live_size_after_gc_new_space;
 
   // Allocated since GC.
   intptr_t allocated_since_gc_new_space;
   intptr_t allocated_since_gc_old_space;
   intptr_t allocated_size_since_gc_new_space;
   intptr_t allocated_size_since_gc_old_space;
 
+  // Accumulator.
+  int64_t accumulated_post_gc_new_space;
+  int64_t accumulated_post_gc_old_space;
+  int64_t accumulated_post_gc_size_new_space;
+  int64_t accumulated_post_gc_size_old_space;
+
+  // Offset used when zeroing accumulators.
+  intptr_t accumulator_new_space_offset;
+  intptr_t accumulator_old_space_offset;
+  intptr_t accumulator_size_new_space_offset;
+  intptr_t accumulator_size_old_space_offset;

[turnidge, 2014/02/27 18:29:13]

 Notes from our offline discussion:

struct AllocStats {
  intptr_t old_count;
  intptr_t new_count;
  intptr_t old_size;
  intptr_t new_size;

  AddOld(intptr_t sz);
  AddNew(intptr_t sz);
  Reset();
}

AllocStats pre_gc;
AllocStats post_gc;

AllocStats recent;
AllocStats accumulated;
AllocStats last_reset;

[Cutch, 2014/02/27 21:50:33]

Done.

+
   static intptr_t allocated_since_gc_new_space_offset() {
     return OFFSET_OF(ClassHeapStats, allocated_since_gc_new_space);
   }
   static intptr_t allocated_since_gc_old_space_offset() {
     return OFFSET_OF(ClassHeapStats, allocated_since_gc_old_space);
   }
   static intptr_t allocated_size_since_gc_new_space_offset() {
     return OFFSET_OF(ClassHeapStats, allocated_size_since_gc_new_space);
   }
   static intptr_t allocated_size_since_gc_old_space_offset() {
     return OFFSET_OF(ClassHeapStats, allocated_size_since_gc_old_space);
   }
 
   void Initialize();
   void ResetAtNewGC();
   void ResetAtOldGC();
+  void ResetAccumulator();
   void UpdateSize(intptr_t instance_size);
   void PrintTOJSONArray(const Class& cls, JSONArray* array);
 };
 
 
 class ClassTable {
  public:
   ClassTable();
   ~ClassTable();
 
@@ skipping 39 matching lines @@
     return reinterpret_cast<uword>(predefined_class_heap_stats_table_);
   }
 
   // Used by generated code.
   uword ClassStatsTableAddress() {
     return reinterpret_cast<uword>(&class_heap_stats_table_);
   }
 
 
   void AllocationProfilePrintToJSONStream(JSONStream* stream);
+  void ResetAllocationAccumulators();
 
  private:
   friend class MarkingVisitor;
   friend class ScavengerVisitor;
   friend class ClassHeapStatsTestHelper;
   static const int initial_capacity_ = 512;
   static const int capacity_increment_ = 256;
 
   static bool ShouldUpdateSizeForClassId(intptr_t cid);
 
   intptr_t top_;
   intptr_t capacity_;
 
   RawClass** table_;
   ClassHeapStats* class_heap_stats_table_;
 
   ClassHeapStats* predefined_class_heap_stats_table_;
 
   ClassHeapStats* StatsAt(intptr_t cid);
   void UpdateLiveOld(intptr_t cid, intptr_t size);
   void UpdateLiveNew(intptr_t cid, intptr_t size);
 
   DISALLOW_COPY_AND_ASSIGN(ClassTable);
 };
 
 }  // namespace dart
 
 #endif  // VM_CLASS_TABLE_H_