Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17301008: Remove =List in JS, use JSExtendableArray instead. (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, sra1, blois
Visibility:
Public.

Description

Remove =List in JS, use JSExtendableArray instead. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=24319

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -86 lines) Patch
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 5 chunks +4 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/types.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart View 1 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 2 chunks +10 lines, -7 lines 0 comments Download
M sdk/lib/_internal/lib/foreign_helper.dart View 1 2 chunks +0 lines, -7 lines 0 comments Download
M sdk/lib/_internal/lib/isolate_helper.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/js_array.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 1 7 chunks +7 lines, -14 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
sdk/lib/_internal/lib/js_rti.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/js_string.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/json_patch.dart View 1 4 chunks +6 lines, -3 lines 0 comments Download
M sdk/lib/_internal/lib/native_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/regexp_helper.dart View 1 3 chunks +6 lines, -4 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/html/html_common/conversions.dart View 1 6 chunks +7 lines, -6 lines 0 comments Download
M sdk/lib/html/html_common/html_common_dart2js.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 3 chunks +11 lines, -8 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
7 years, 6 months ago (2013-06-20 11:53:56 UTC) #1
kasperl
LGTM. Did you regenerate the files that are auto-generated from IDL or did you edit ...
7 years, 6 months ago (2013-06-21 06:03:55 UTC) #2
ngeoffray
Thanks Kasper! I did not re-generate the html file in the first patch set. I ...
7 years, 6 months ago (2013-06-24 09:47:23 UTC) #3
ngeoffray
7 years, 6 months ago (2013-06-24 10:09:33 UTC) #4
Message was sent while issue was closed. 
Committed patchset #7 manually as r24319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698