Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: sdk/lib/_internal/lib/regexp_helper.dart

Issue 17301008: Remove =List in JS, use JSExtendableArray instead. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/lib/native_helper.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/regexp_helper.dart
===================================================================
--- sdk/lib/_internal/lib/regexp_helper.dart (revision 24309)
+++ sdk/lib/_internal/lib/regexp_helper.dart (working copy)
@@ -84,8 +84,10 @@
}
Match firstMatch(String str) {
- List<String> m =
- JS('=List|Null', r'#.exec(#)', _nativeRegExp, checkString(str));
+ List<String> m = JS('JSExtendableArray|Null',
+ r'#.exec(#)',
+ _nativeRegExp,
+ checkString(str));
if (m == null) return null;
return new _MatchImplementation(this, m);
}
@@ -108,7 +110,7 @@
Match _execGlobal(String string, int start) {
Object regexp = _nativeGlobalVersion;
JS("void", "#.lastIndex = #", regexp, start);
- List match = JS("=List|Null", "#.exec(#)", regexp, string);
+ List match = JS("JSExtendableArray|Null", "#.exec(#)", regexp, string);
if (match == null) return null;
return new _MatchImplementation(this, match);
}
@@ -116,7 +118,7 @@
Match _execAnchored(String string, int start) {
Object regexp = _nativeAnchoredVersion;
JS("void", "#.lastIndex = #", regexp, start);
- List match = JS("=List|Null", "#.exec(#)", regexp, string);
+ List match = JS("JSExtendableArray|Null", "#.exec(#)", regexp, string);
if (match == null) return null;
// If the last capture group participated, the original regexp did not
// match at the start position.
« no previous file with comments | « sdk/lib/_internal/lib/native_helper.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698