Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1715583003: Use boolean selector syntax for tags. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use boolean selector syntax for tags. The --tags and --exclude-tags flags now support boolean selector syntax, as do the keys in the "tags" configuration field. Closes #16 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/832d1046837177f41f896336efe5d91c1cecf70e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -154 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M README.md View 1 chunk +3 lines, -1 line 0 comments Download
M doc/package_config.md View 2 chunks +15 lines, -3 lines 0 comments Download
M lib/src/backend/metadata.dart View 1 6 chunks +28 lines, -30 lines 0 comments Download
M lib/src/runner.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M lib/src/runner/configuration.dart View 6 chunks +28 lines, -25 lines 0 comments Download
M lib/src/runner/configuration/args.dart View 4 chunks +21 lines, -20 lines 0 comments Download
M lib/src/runner/configuration/load.dart View 2 chunks +6 lines, -12 lines 0 comments Download
M test/backend/metadata_test.dart View 6 chunks +25 lines, -21 lines 0 comments Download
M test/runner/configuration/configuration_test.dart View 2 chunks +24 lines, -17 lines 0 comments Download
M test/runner/configuration/tags_test.dart View 2 chunks +28 lines, -2 lines 0 comments Download
M test/runner/runner_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M test/runner/tag_test.dart View 3 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 10 months ago (2016-02-19 00:31:56 UTC) #1
kevmoo
awesome LGTM https://codereview.chromium.org/1715583003/diff/1/lib/src/backend/metadata.dart File lib/src/backend/metadata.dart (right): https://codereview.chromium.org/1715583003/diff/1/lib/src/backend/metadata.dart#newcode8 lib/src/backend/metadata.dart:8: import 'package:boolean_selector/boolean_selector.dart'; sorting
4 years, 10 months ago (2016-02-19 00:45:35 UTC) #2
nweiz
Code review changes
4 years, 10 months ago (2016-02-19 00:53:08 UTC) #3
nweiz
https://codereview.chromium.org/1715583003/diff/1/lib/src/backend/metadata.dart File lib/src/backend/metadata.dart (right): https://codereview.chromium.org/1715583003/diff/1/lib/src/backend/metadata.dart#newcode8 lib/src/backend/metadata.dart:8: import 'package:boolean_selector/boolean_selector.dart'; On 2016/02/19 00:45:35, kevmoo wrote: > sorting ...
4 years, 10 months ago (2016-02-19 00:54:04 UTC) #4
nweiz
4 years, 10 months ago (2016-02-19 00:54:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
832d1046837177f41f896336efe5d91c1cecf70e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698