Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: lib/src/runner.dart

Issue 1715583003: Use boolean selector syntax for tags. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/backend/metadata.dart ('k') | lib/src/runner/configuration.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner.dart
diff --git a/lib/src/runner.dart b/lib/src/runner.dart
index 80f19b3a31dc0aab95865ae327217d6c6eeb0e2b..4da2710bc7909ce856362c1c3cd44e7b3b50736f 100644
--- a/lib/src/runner.dart
+++ b/lib/src/runner.dart
@@ -202,15 +202,10 @@ class Runner {
}
// If the user provided tags, skip tests that don't match all of them.
- if (!_config.includeTags.isEmpty &&
- !test.metadata.tags.containsAll(_config.includeTags)) {
- return false;
- }
+ if (!_config.includeTags.evaluate(test.metadata.tags)) return false;
// Skip tests that do match any tags the user wants to exclude.
- if (_config.excludeTags.intersection(test.metadata.tags).isNotEmpty) {
- return false;
- }
+ if (_config.excludeTags.evaluate(test.metadata.tags)) return false;
return true;
});
« no previous file with comments | « lib/src/backend/metadata.dart ('k') | lib/src/runner/configuration.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698