Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: lib/src/runner/configuration/load.dart

Issue 1715583003: Use boolean selector syntax for tags. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/configuration/args.dart ('k') | test/backend/metadata_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/configuration/load.dart
diff --git a/lib/src/runner/configuration/load.dart b/lib/src/runner/configuration/load.dart
index 717746758075683409b84fdc43625f34ec56c62c..147aca6c7d7f4df21b973ee1284eabbe86a31a44 100644
--- a/lib/src/runner/configuration/load.dart
+++ b/lib/src/runner/configuration/load.dart
@@ -4,6 +4,7 @@
import 'dart:io';
+import 'package:boolean_selector/boolean_selector.dart';
import 'package:glob/glob.dart';
import 'package:path/path.dart' as p;
import 'package:source_span/source_span.dart';
@@ -69,18 +70,11 @@ class _ConfigurationLoader {
return tagNode.value;
});
- var tags = _getMap("tags", key: (keyNode) {
- _validate(keyNode, "tags key must be a string.",
- (value) => value is String);
- _validate(
- keyNode,
- "Invalid tag. Tags must be (optionally hyphenated) Dart identifiers.",
- (value) => value.contains(anchoredHyphenatedIdentifier));
-
- return keyNode.value;
- }, value: (valueNode) {
- return _nestedConfig(valueNode, "tag value", runnerConfig: false);
- });
+ var tags = _getMap("tags",
+ key: (keyNode) => _parseNode(keyNode, "tags key",
+ (value) => new BooleanSelector.parse(value)),
+ value: (valueNode) =>
+ _nestedConfig(valueNode, "tag value", runnerConfig: false));
return new Configuration(
verboseTrace: verboseTrace,
« no previous file with comments | « lib/src/runner/configuration/args.dart ('k') | test/backend/metadata_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698