Issue 16959004: Remove Encoding.BINARY

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16959004: Remove Encoding.BINARY (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove Encoding.BINARY THe Encoding.BINARY was a bad idea. It is now removed and null is used to indicate binary result from Process.run. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23977

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -23 lines)			Patch
M	runtime/bin/process_patch.dart	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	sdk/lib/io/process.dart	View	2 chunks	+11 lines, -8 lines	0 comments	Download
M	sdk/lib/io/string_transformer.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tests/standalone/io/process_run_output_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_std_io_script2.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

7 years, 6 months ago (2013-06-13 13:06:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23977 (presubmit successful).