Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: runtime/bin/process_patch.dart

Issue 16959004: Remove Encoding.BINARY (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/io/process.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_patch.dart
diff --git a/runtime/bin/process_patch.dart b/runtime/bin/process_patch.dart
index f74e814af0856df0fb184d4e0ee76b6960e982d8..ba50c9f5a0e67730efd96c42b63bdc4668a311a1 100644
--- a/runtime/bin/process_patch.dart
+++ b/runtime/bin/process_patch.dart
@@ -336,10 +336,6 @@ Future<ProcessResult> _runNonInteractiveProcess(String path,
bool runInShell,
Encoding stdoutEncoding,
Encoding stderrEncoding) {
- // Extract output encoding options and verify arguments.
- if (stdoutEncoding == null) stdoutEncoding = Encoding.BINARY;
- if (stderrEncoding == null) stderrEncoding = Encoding.BINARY;
-
// Start the underlying process.
return Process.start(path,
arguments,
@@ -353,7 +349,7 @@ Future<ProcessResult> _runNonInteractiveProcess(String path,
// Setup stdout and stderr handling.
Future foldStream(Stream<List<int>> stream, Encoding encoding) {
- if (encoding == Encoding.BINARY) {
+ if (encoding == null) {
return stream
.fold(
new _BufferList(),
« no previous file with comments | « no previous file | sdk/lib/io/process.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698