Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: sdk/lib/io/process.dart

Issue 16959004: Remove Encoding.BINARY (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/process_patch.dart ('k') | sdk/lib/io/string_transformer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/process.dart
diff --git a/sdk/lib/io/process.dart b/sdk/lib/io/process.dart
index 9ff803d06250952258f1eec777bf21067323099c..6c79c12d226d86864f553b4823e10f3b03d0ffb5 100644
--- a/sdk/lib/io/process.dart
+++ b/sdk/lib/io/process.dart
@@ -115,13 +115,16 @@ abstract class Process {
* passed in.
*
* If [runInShell] is true, the process will be spawned through a system
- * shell. On Linux and Mac OS, [:/bin/sh:] is used, while
- * [:%WINDIR%\system32\cmd.exe:] is used on Windows.
+ * shell. On Linux and Mac OS, `/bin/sh` is used, while
+ * `%WINDIR%\system32\cmd.exe` is used on Windows.
*
- * The encoding used for text on stdout and stderr can be set by changing
- * [stdoutEncoding] and [stderrEncoding]. The default encoding is SYSTEM.
+ * The encoding used for decoding `stdout` and `stderr` into text is
+ * controlled through [stdoutEncoding] and [stderrEncoding]. The
+ * default encoding is `Encoding.SYSTEM`. If `null` is used no
+ * decoding will happen and the [ProcessResult] will hold binary
+ * data.
*
- * Returns a [:Future<ProcessResult>:] that completes with the
+ * Returns a `Future<ProcessResult>` that completes with the
* result of running the process, i.e., exit code, standard out and
* standard in.
*/
@@ -202,15 +205,15 @@ abstract class ProcessResult {
/**
* Standard output from the process. The value used for the
* `stdoutEncoding` argument to `Process.run` determins the type. If
- * `Encoding.BINARY` was used this value is of type `List<int>
- * otherwise it is of type `String`.
+ * `null` was used this value is of type `List<int> otherwise it is
+ * of type `String`.
*/
get stdout;
/**
* Standard error from the process. The value used for the
* `stderrEncoding` argument to `Process.run` determins the type. If
- * `Encoding.BINARY` was used this value is of type `List<int>
+ * `null` was used this value is of type `List<int>
* otherwise it is of type `String`.
*/
get stderr;
« no previous file with comments | « runtime/bin/process_patch.dart ('k') | sdk/lib/io/string_transformer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698