Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 167713002: Improved how closures are displayed by <instance-ref>. (Closed)

Created:
6 years, 10 months ago by turnidge
Modified:
6 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Improved how closures are displayed by <instance-ref>. Make <optimized out> look a bit nicer. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=32760

Patch Set 1 #

Patch Set 2 : reupload #

Patch Set 3 : again #

Patch Set 4 : #

Patch Set 5 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -11 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 4 3 chunks +11 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 4 3 chunks +11 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html View 2 chunks +4 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart View 2 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 1 chunk +15 lines, -2 lines 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
6 years, 10 months ago (2014-02-14 21:43:31 UTC) #1
Cutch
lgtm
6 years, 10 months ago (2014-02-18 15:39:19 UTC) #2
turnidge
6 years, 10 months ago (2014-02-18 19:45:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r32760 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698