Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart

Issue 167713002: Improved how closures are displayed by <instance-ref>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart
index acd06464d0594a6a85dd259efa07e71f8f52cfcb..74db7e08333c118f3fa105a881ef948f9c579163 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.dart
@@ -117,6 +117,10 @@ class ObservatoryElement extends PolymerElement {
return type == '@Instance';
}
+ bool isClosureRef(String type) {
+ return type == '@Closure';
+ }
+
bool isListRef(String type) {
return (type == '@GrowableObjectArray' ||
type == '@Array');
@@ -129,8 +133,9 @@ class ObservatoryElement extends PolymerElement {
'@Biginit',
'@Bool',
'@String',
+ '@Closure',
'@Instance',
- '@GrowableObjectArray'
+ '@GrowableObjectArray',
'@Array'].contains(type));
}
}
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698