Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html

Issue 167713002: Improved how closures are displayed by <instance-ref>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <head> 1 <head>
2 <link rel="import" href="observatory_element.html"> 2 <link rel="import" href="observatory_element.html">
3 <link rel="import" href="service_ref.html"> 3 <link rel="import" href="service_ref.html">
4 </head> 4 </head>
5 <polymer-element name="instance-ref" extends="service-ref"> 5 <polymer-element name="instance-ref" extends="service-ref">
6 <template> 6 <template>
7 <style> 7 <style>
8 .memberList { 8 .memberList {
9 margin-left: 3em; 9 margin-left: 3em;
10 border-spacing: 0; 10 border-spacing: 0;
(...skipping 12 matching lines...) Expand all
23 <template if="{{ isNullRef(ref['type']) }}"> 23 <template if="{{ isNullRef(ref['type']) }}">
24 {{ name }} 24 {{ name }}
25 </template> 25 </template>
26 26
27 <template if="{{ (isStringRef(ref['type']) || 27 <template if="{{ (isStringRef(ref['type']) ||
28 isBoolRef(ref['type']) || 28 isBoolRef(ref['type']) ||
29 isIntRef(ref['type'])) }}"> 29 isIntRef(ref['type'])) }}">
30 <a href="{{ url }}">{{ name }}</a> 30 <a href="{{ url }}">{{ name }}</a>
31 </template> 31 </template>
32 32
33 <template if="{{ isClosureRef(ref['type']) }}">
34 <a href="{{ url }}">
35 {{ ref['closureFunc']['user_name'] }}
36 </a>
37 </template>
38
33 <template if="{{ isInstanceRef(ref['type']) }}"> 39 <template if="{{ isInstanceRef(ref['type']) }}">
34 <a href="{{ url }}"><em>{{ ref['class']['user_name'] }}</em></a> { 40 <a href="{{ url }}"><em>{{ ref['class']['user_name'] }}</em></a> {
35 <a on-click="{{ toggleExpand }}">...</a> 41 <a on-click="{{ toggleExpand }}">...</a>
36 <template if="{{ expanded }}"> 42 <template if="{{ expanded }}">
37 <table class="memberList"> 43 <table class="memberList">
38 <tr template repeat="{{ field in ref['fields'] }}"> 44 <tr template repeat="{{ field in ref['fields'] }}">
39 45
40 <td class="member">{{ field['decl']['user_name'] }}</td> 46 <td class="member">{{ field['decl']['user_name'] }}</td>
41 <td class="member"> 47 <td class="member">
42 <instance-ref app="{{ app }}" ref="{{ field['value'] }}"></insta nce-ref> 48 <instance-ref app="{{ app }}" ref="{{ field['value'] }}"></insta nce-ref>
(...skipping 17 matching lines...) Expand all
60 </tr> 66 </tr>
61 </table> 67 </table>
62 </template> 68 </template>
63 } 69 }
64 </template> 70 </template>
65 71
66 </div> 72 </div>
67 </template> 73 </template>
68 <script type="application/dart" src="instance_ref.dart"></script> 74 <script type="application/dart" src="instance_ref.dart"></script>
69 </polymer-element> 75 </polymer-element>
OLDNEW
« no previous file with comments | « runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698