Issue 16695007: Fix decoding of object pool access in code patching on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16695007: Fix decoding of object pool access in code patching on ARM. (Closed)

Created:
7 years, 6 months ago by regis

Modified:
7 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix decoding of object pool access in code patching on ARM. Fix shift by zero and divide by one on ARM. Update test status files. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23920

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -43 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_arm.h	View	1 2 3	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/instructions_arm.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3	1 chunk	+12 lines, -24 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 2 3	2 chunks	+4 lines, -5 lines	0 comments	Download
M	tests/lib/lib.status	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/standalone/standalone.status	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

regis

On 2013/06/12 16:12:33, zra wrote: > lgtm Thanks, but I need another pass over the ...

7 years, 6 months ago (2013-06-12 16:18:26 UTC) #3

regis

7 years, 6 months ago (2013-06-12 16:57:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r23920 (presubmit successful).