runtime/vm/intermediate_language_arm.cc - Issue 16695007: Fix decoding of object pool access in code patching on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 16695007: Fix decoding of object pool access in code patching on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm.cc

===================================================================

--- runtime/vm/intermediate_language_arm.cc (revision 23918)

+++ runtime/vm/intermediate_language_arm.cc (working copy)

@@ -2091,7 +2091,7 @@

const intptr_t kCountLimit = 0x1F;

const intptr_t value = Smi::Cast(constant).Value();

if (value == 0) {

- // No code needed.

+ __ MoveRegister(result, left);

} else if ((value < 0) || (value >= kCountLimit)) {

// This condition may not be known earlier in some cases because

// of constant propagation, inlining, etc.

@@ -2272,7 +2272,7 @@

case Token::kTRUNCDIV: {

const intptr_t value = Smi::Cast(constant).Value();

if (value == 1) {

- // Do nothing.

+ __ MoveRegister(result, left);

break;

} else if (value == -1) {

// Check the corner case of dividing the 'MIN_SMI' with -1, in which

« no previous file with comments | « runtime/vm/instructions_arm.cc ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »