Issue 16611004: Improve java2dart code style - relax 'don't reference variable name in its initializer'.

Issue 16611004: Improve java2dart code style - relax 'don't reference variable name in its initializer'. (Closed)

Created:
7 years, 6 months ago by scheglov

Modified:
7 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improve java2dart code style - relax 'don't reference variable name in its initializer'. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23795

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2556 lines, -2443 lines)			Patch
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java	View	2 chunks	+35 lines, -2 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/ast.dart	View	44 chunks	+288 lines, -288 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/constant.dart	View	6 chunks	+31 lines, -31 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/element.dart	View	31 chunks	+130 lines, -130 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/engine.dart	View	11 chunks	+32 lines, -32 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/html.dart	View	5 chunks	+16 lines, -16 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/parser.dart	View	40 chunks	+178 lines, -178 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/resolver.dart	View	210 chunks	+1006 lines, -1006 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/scanner.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/sdk_io.dart	View	2 chunks	+20 lines, -20 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/source_io.dart	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/ast_test.dart	View	5 chunks	+13 lines, -13 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/element_test.dart	View	23 chunks	+139 lines, -139 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/parser_test.dart	View	45 chunks	+201 lines, -201 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/resolver_test.dart	View	63 chunks	+338 lines, -338 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/scanner_test.dart	View	5 chunks	+24 lines, -24 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/test_support.dart	View	2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

7 years, 6 months ago (2013-06-10 04:06:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23795 (presubmit successful).

Expand Messages | Collapse Messages