editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java - Issue 16611004: Improve java2dart code style - relax 'don't reference variable name in its initializer'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

Issue 16611004: Improve java2dart code style - relax 'don't reference variable name in its initializer'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java ('k') | editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

diff --git a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

index cc0fde5e7a55dd04a1fd9f7e2411bc9d3f2f38a4..798cc0884f800cb5f30dc421bca68367d4199228 100644

--- a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

+++ b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

@@ -324,8 +324,8 @@ public class MainEngine {

makeSource("Object visitImportDirective(ImportDirective directive) {", " return null;"));

source = replaceSourceFragment(

source,

- "fullName2.replaceAll(new String.fromCharCode(JavaFile.separatorChar), '/')",

- "fullName2.replaceAll(r'\\', '/')");

+ "fullName.replaceAll(new String.fromCharCode(JavaFile.separatorChar), '/')",

+ "fullName.replaceAll(r'\\', '/')");

Files.write(source, new File(targetFolder + "/resolver.dart"), Charsets.UTF_8);

}

{