Improve java2dart code style - relax 'don't reference variable name in its initializer'.

editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java

 /*
  * Copyright (c) 2012, the Dart project authors.
  * 
  * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  * 
  * http://www.eclipse.org/legal/epl-v10.html
  * 
  * Unless required by applicable law or agreed to in writing, software distributed under the License
  * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
@@ skipping 1379 matching lines @@
             "class Test extends B {",
             "  static int foo() => 42;",
             "  static void bar() {",
             "    int foo3 = foo();",
             "    baz(foo3);",
             "  }",
             "}"),
         getFormattedSource(unit));
   }
 
+  public void test_giveUniqueName_variableInitializer_propertyReference() throws Exception {
+    File file = setFileLines(
+        "test/Test.java",
+        toString(
+            "// filler filler filler filler filler filler filler filler filler filler",
+            "package test;",
+            "public class Test {",
+            "  int getFoo() {return 42;}",
+            "  static void main() {",
+            "    int foo = getFoo();",
+            "    process(foo);",
+            "  }",
+            "  void process(int x) {}",
+            "}",
+            ""));
+    Context context = new Context();
+    context.addSourceFolder(tmpFolder);
+    context.addSourceFile(file);
+    CompilationUnit unit = context.translate();
+    // convert to properties and run variable checks again
+    new PropertySemanticProcessor(context).process(unit);
+    context.ensureNoVariableNameReferenceFromInitializer(unit);
+    // verify
+    assertEquals(
+        toString(
+            "class Test {",
+            "  int get foo => 42;",
+            "  static void main() {",
+            "    int foo = this.foo;",
+            "    process(foo);",
+            "  }",
+            "  void process(int x) {",
+            "  }",
+            "}"),
+        getFormattedSource(unit));
+  }
+
+  public void test_giveUniqueName_variableInitializer_qualifiedReference() throws Exception {
+    File file = setFileLines(
+        "test/Test.java",
+        toString(
+            "// filler filler filler filler filler filler filler filler filler filler",
+            "package test;",
+            "public class Test {",
+            "  int foo() {return 42;}",
+            "  int bar;",
+            "  static void mainA() {",
+            "    int foo = this.foo();",
+            "    process(foo);",
+            "  }",
+            "  static void mainB() {",
+            "    int bar = this.bar;",
+            "    process(bar);",
+            "  }",
+            "  void process(int x) {}",
+            "}",
+            ""));
+    Context context = new Context();
+    context.addSourceFolder(tmpFolder);
+    context.addSourceFile(file);
+    CompilationUnit unit = context.translate();
+    assertEquals(
+        toString(
+            "class Test {",
+            "  int foo() => 42;",
+            "  int bar = 0;",
+            "  static void mainA() {",
+            "    int foo = this.foo();",
+            "    process(foo);",
+            "  }",
+            "  static void mainB() {",
+            "    int bar = this.bar;",
+            "    process(bar);",
+            "  }",
+            "  void process(int x) {",
+            "  }",
+            "}"),
+        getFormattedSource(unit));
+  }
+
   public void test_giveUniqueName_withStatic() throws Exception {
     setFileLines(
         "test/Super.java",
         toString(
             "// filler filler filler filler filler filler filler filler filler filler",
             "package test;",
             "public class Super {",
             "  static int add(int a, int b) {return a + b;}",
             "}",
             ""));
@@ skipping 687 matching lines @@
             "  Test_A(List<int> args) {",
             "  }",
             "}",
             "class Test_B extends Test_A {",
             "  Test_B(List<int> args) : super(args) {",
             "  }",
             "}"),
         getFormattedSource(unit));
   }
 }