Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 165873005: Do not overwrite values on plurals/genders with the results of constant evaluation (Closed)

Created:
6 years, 10 months ago by Alan Knight
Modified:
6 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not overwrite values on plurals/genders with the results of constant evaluation BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=32832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M pkg/intl/lib/extract_messages.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/intl/lib/generate_localized.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/message_extraction/foo_messages_de_DE.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/intl/test/message_extraction/foo_messages_fr.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/intl/test/message_extraction/make_hardcoded_translation.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/intl/test/message_extraction/sample_with_messages.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M pkg/intl/test/message_extraction/verify_messages.dart View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
In order to parse examples, we introduced a ConstantEvaluator pass over the string values. However, ...
6 years, 10 months ago (2014-02-19 23:24:47 UTC) #1
Emily Fortuna
lgtm
6 years, 10 months ago (2014-02-19 23:39:54 UTC) #2
Alan Knight
6 years, 10 months ago (2014-02-19 23:50:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698