pkg/intl/lib/extract_messages.dart - Issue 165873005: Do not overwrite values on plurals/genders with the results of constant evaluation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/intl/lib/extract_messages.dart

Issue 165873005: Do not overwrite values on plurals/genders with the results of constant evaluation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/intl/lib/extract_messages.dart

diff --git a/pkg/intl/lib/extract_messages.dart b/pkg/intl/lib/extract_messages.dart

index aca18da7743a47983c310ab3225772d428dd495a..328b18de87e9ea4ea98d86b69d8fb11b6b3cdfa7 100644

--- a/pkg/intl/lib/extract_messages.dart

+++ b/pkg/intl/lib/extract_messages.dart

@@ -282,8 +282,6 @@ class MessageFindingVisitor extends GeneralizingASTVisitor {

void setAttribute(MainMessage msg, String fieldName, String fieldValue) {

if (["name", "desc", "examples", "args"].contains(fieldName)) {

msg[fieldName] = fieldValue;

- } else {

- pluralOrGender[fieldName] = fieldValue;

}

return _messageFromNode(node, extractFromPluralOrGender, setAttribute);

« no previous file with comments | « no previous file | pkg/intl/lib/generate_localized.dart » ('j') | no next file with comments »