pkg/intl/test/message_extraction/make_hardcoded_translation.dart - Issue 165873005: Do not overwrite values on plurals/genders with the results of constant evaluation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/intl/test/message_extraction/make_hardcoded_translation.dart

Issue 165873005: Do not overwrite values on plurals/genders with the results of constant evaluation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/intl/test/message_extraction/foo_messages_fr.dart ('k') | pkg/intl/test/message_extraction/sample_with_messages.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/intl/test/message_extraction/make_hardcoded_translation.dart

diff --git a/pkg/intl/test/message_extraction/make_hardcoded_translation.dart b/pkg/intl/test/message_extraction/make_hardcoded_translation.dart

index e9585647fd8f322c5d5decc0a6acf9ab1a2df0e0..543ed6c0fe59e7fd8852f7537a932b28728528c8 100644

--- a/pkg/intl/test/message_extraction/make_hardcoded_translation.dart

+++ b/pkg/intl/test/message_extraction/make_hardcoded_translation.dart

@@ -97,6 +97,11 @@ var french = {

['female', 'femme'],

['other', 'autre'],

], null)),

+ "pluralThatFailsParsing" : writer.write(new Plural.from("noOfThings",

+ [

+ ['one', '1 chose:'],

+ ['other', '\$noOfThings choses:']

+ ], null)),

"nestedOuter" : writer.write ( new Plural.from("number",

[

['other', new Gender.from("gen",

@@ -183,6 +188,11 @@ var german = {

['female', 'Frau'],

['other', 'andere'],

], null)),

+ "pluralThatFailsParsing" : writer.write(new Plural.from("noOfThings",

+ [

+ ['one', 'eins:'],

+ ['other', '\$noOfThings Dinge:']

+ ], null)),

"nestedOuter" : writer.write (new Plural.from("number",

[

['other', new Gender.from("gen",