Issue 165643003: Rework <script-ref>: - optional 'line' parameter - use a shorter version of the script url in the a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165643003: Rework <script-ref>: - optional 'line' parameter - use a shorter version of the script url in the a… (Closed)

Created:
6 years, 10 months ago by turnidge

Modified:
6 years, 10 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rework <script-ref>: - optional 'line' parameter - use a shorter version of the script url in the anchor text - keep long script url in hover text The links for script-ref's now have a ?line=### url parameter which is currently ignored in the script view page. Added an optional 'isolate' parameter for all service-ref's. This allows us to explicitly specify our "current" isolate. Redo function/script reference in the isolate summary page to use <function-ref> and <service-ref> now that we can specify an isolate. Add a missing comma in observatory_element.dart. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=32772

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1137 lines, -953 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2	4 chunks	+12 lines, -14 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View		247 chunks	+523 lines, -457 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2	4 chunks	+12 lines, -14 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View		247 chunks	+523 lines, -457 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html	View	1 2	2 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.dart	View	1 2	1 chunk	+38 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.dart	View	1	3 chunks	+18 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

6 years, 10 months ago (2014-02-19 00:37:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r32772 (presubmit successful).

Expand Messages | Collapse Messages

Issue 165643003: Rework <script-ref>: - optional 'line' parameter - use a shorter version of the script url in the a… (Closed)

Description

Patch Set 1 #

Patch Set 2 : edits #

Patch Set 3 : gen js #

Messages