Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Unified Diff: runtime/bin/vmservice/client/deployed/web/index_devtools.html

Issue 165643003: Rework <script-ref>: - optional 'line' parameter - use a shorter version of the script url in the a… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/deployed/web/index_devtools.html
diff --git a/runtime/bin/vmservice/client/deployed/web/index_devtools.html b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
index f69ea29b65815a9569ba702d56a009593c3a207e..f0ef610b602948572af7a0ca53be6049c9bb4548 100644
--- a/runtime/bin/vmservice/client/deployed/web/index_devtools.html
+++ b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
@@ -356,7 +356,13 @@
</div>
</template>
-</polymer-element><polymer-element name="isolate-summary" extends="observatory-element">
+</polymer-element><polymer-element name="script-ref" extends="service-ref">
+<template>
+ <a title="{{ hoverText }}" href="{{ url }}">{{ name }}</a>
+</template>
+
+</polymer-element>
+<polymer-element name="isolate-summary" extends="observatory-element">
<template>
<div class="row">
<div class="col-md-1">
@@ -436,12 +442,8 @@
</div>
<div class="col-md-6">
<template if="{{ isolate.topFrame != null }}">
- <a href="{{ app.locationManager.relativeLink(isolate.id, isolate.topFrame['function']['id']) }}">
- {{ isolate.topFrame['function']['user_name'] }}
- </a>
- (<a href="{{ app.locationManager.relativeLink(isolate.id, isolate.topFrame['script']['id']) }}">
- {{ isolate.topFrame | fileAndLine }}
- </a>)
+ <function-ref app="{{ app }}" isolate="{{ isolate }}" ref="{{ isolate.topFrame['function'] }}"></function-ref>
+ (<script-ref app="{{ app }}" isolate="{{ isolate }}" ref="{{ isolate.topFrame['script'] }}" line="{{ isolate.topFrame['line'] }}"></script-ref>)
<br>
<pre>{{ isolate.topFrame['line'] }} &nbsp; {{ isolate.topFrame['lineString'] }}</pre>
</template>
@@ -534,12 +536,7 @@
</template>
</polymer-element>
-<polymer-element name="script-ref" extends="service-ref">
-<template>
- <a href="{{ url }}">{{ name }}</a>
-</template>
-
-</polymer-element><polymer-element name="library-view" extends="observatory-element">
+<polymer-element name="library-view" extends="observatory-element">
<template>
<div class="alert alert-success">Library {{ library['name'] }}</div>
<div class="alert alert-info">Scripts</div>
@@ -704,7 +701,8 @@
</div>
<div class="col-md-9">
<function-ref app="{{ app }}" ref="{{ frame['function'] }}"></function-ref>
- ( <script-ref app="{{ app }}" ref="{{ frame['script'] }}"></script-ref>:{{ frame['line'] }} )
+ ( <script-ref app="{{ app }}" ref="{{ frame['script'] }}" line="{{ frame['line'] }}">
+ </script-ref> )
</div>
<div class="col-md-1"></div>
</div>

Powered by Google App Engine
This is Rietveld 408576698