Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html

Issue 165643003: Rework <script-ref>: - optional 'line' parameter - use a shorter version of the script url in the a… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html b/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html
index d56d00d4e82f70bcfdf5afafd2a7469c4be92153..957aa9c9850727f1d32dc8ea9114bf56310e0bb8 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html
@@ -1,5 +1,7 @@
<head>
+ <link rel="import" href="function_ref.html">
<link rel="import" href="observatory_element.html">
+ <link rel="import" href="script_ref.html">
</head>
<polymer-element name="isolate-summary" extends="observatory-element">
<template>
@@ -81,12 +83,11 @@
</div>
<div class="col-md-6">
<template if="{{ isolate.topFrame != null }}">
- <a href="{{ app.locationManager.relativeLink(isolate.id, isolate.topFrame['function']['id']) }}">
- {{ isolate.topFrame['function']['user_name'] }}
- </a>
- (<a href="{{ app.locationManager.relativeLink(isolate.id, isolate.topFrame['script']['id']) }}">
- {{ isolate.topFrame | fileAndLine }}
- </a>)
+ <function-ref app="{{ app }}" isolate="{{ isolate }}"
+ ref="{{ isolate.topFrame['function'] }}"></function-ref>
+ (<script-ref app="{{ app }}" isolate="{{ isolate }}"
+ ref="{{ isolate.topFrame['script'] }}"
+ line="{{ isolate.topFrame['line'] }}"></script-ref>)
<br>
<pre>{{ isolate.topFrame['line'] }} &nbsp; {{ isolate.topFrame['lineString'] }}</pre>
</template>

Powered by Google App Engine
This is Rietveld 408576698