Issue 16206008: Fix-up RegExp implementations.

Issue 16206008: Fix-up RegExp implementations. (Closed)

Created:
7 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 6 months ago

Reviewers:
regis, floitsch, ngeoffray

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix-up RegExp implementations. VM _JSRegExpMatch didn't have correct "pattern" getter and exposed too many members. Also didn't allow matching an empty match at the end of the string with .allMatches. JS RegExp didn't advance the position correctly after an empty match. BUG=http://dartbug.com/1301, http://dartbug.com/6554 R=floitsch@google.com, ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=23675

Patch Set 1 #

Patch Set 2 : Also fix issue 2980 #

Patch Set 3 : Fix 8334 too #

Total comments: 1

Patch Set 4 : Renaming startIndex to index. Add comment. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -41 lines)			Patch
M	runtime/lib/regexp_patch.dart	View	1 2 3	3 chunks	+18 lines, -17 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_string.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/core/regexp.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	tests/language/reg_exp_test.dart	View	1	1 chunk	+18 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Adding Florian. He can review the runtime changes too.

7 years, 6 months ago (2013-06-06 10:36:35 UTC) #3

floitsch

LGTM! https://codereview.chromium.org/16206008/diff/6001/runtime/lib/regexp_patch.dart File runtime/lib/regexp_patch.dart (right): https://codereview.chromium.org/16206008/diff/6001/runtime/lib/regexp_patch.dart#newcode90 runtime/lib/regexp_patch.dart:90: startIndex = match[1]; Add comment that you set ...

7 years, 6 months ago (2013-06-06 11:30:02 UTC) #4

Lasse Reichstein Nielsen

7 years, 6 months ago (2013-06-06 11:44:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r23675 (presubmit successful).

Expand Messages | Collapse Messages